Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #12264 - auto-detection of Python in Visual Studio built binaries when python3.exe does not exist #5765

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

firewave
Copy link
Collaborator

I also suppressed the unwanted output from the system().

@firewave
Copy link
Collaborator Author

I cannot think of an easy way to unit test this right now.

I tested it locally by replacing the binaries to look for with python4.exe and python3.exe.

@danmar
Copy link
Owner

danmar commented Dec 15, 2023

I cannot think of an easy way to unit test this right now.

me neither. I thought about it too.

Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrchr-github chrchr-github merged commit c79ec60 into danmar:main Dec 15, 2023
68 checks passed
@firewave firewave deleted the py-auto-win branch December 15, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants